fix: import mcp json streamable http configs#367
Open
fancyboi999 wants to merge 1 commit intonetease-youdao:mainfrom
Open
fix: import mcp json streamable http configs#367fancyboi999 wants to merge 1 commit intonetease-youdao:mainfrom
fancyboi999 wants to merge 1 commit intonetease-youdao:mainfrom
Conversation
This was referenced Mar 11, 2026
|
This pull request has been inactive for 30 days. It will be automatically closed in 14 days unless there is new activity. If you're still working on this, please leave a comment or push new commits to keep it open. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userData/mcp.jsoninto the existing SQLite-backed MCP store at startupstreamable_httpconfigs into LobsterAI's internalhttptransportSSEandStreamable HTTPare clearly distinguished in the UIRoot Cause
Issue #351 mixed together two separate gaps:
mcp.jsonfiles at all, so dropping a file into the app data directory never surfaced servers in the UIhttpfor streamable HTTP MCP transport, but external configs commonly usestreamable_http, and the UI did not make that distinction obvious enoughSolution
mcp.json, validates entries, mapsstreamable_http/streamable-httptohttp, and writes imported entries intomcp_serversmcp.json-managed records without overriding manually configured serversmcp.jsonimport behavior and alias normalizationStreamable HTTPValidation
npx -p node@24 -p npm@11 -c "npm run compile:electron"npx -p node@24 -c "node --test tests/mcpJsonSync.test.mjs tests/coworkOpenAICompatProxy.sseBoundary.test.mjs tests/coworkOpenAICompatProxy.responses.test.mjs"npx -p node@24 -c "./node_modules/.bin/eslint src/main/mcpJsonSync.ts src/main/mcpStore.ts src/main/main.ts src/renderer/components/mcp/McpServerFormModal.tsx src/renderer/services/i18n.ts tests/mcpJsonSync.test.mjs"npx -p node@24 -p npm@11 -c "npm run build"406 Not Acceptableresponse when the client only acceptstext/event-stream, and succeeds when the client accepts bothapplication/json, text/event-streammcp.jsonimport turns astreamable_httpentry into internaltransportType: "http"Notes
npm run lint -- --quietstill reports pre-existing unrelated lint errors insrc/main/im/nimGateway.tsandsrc/main/im/xiaomifengGateway.tsCloses #351