-
Notifications
You must be signed in to change notification settings - Fork 13
feat: support angular@20 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d1eb0de
test: upgrade demo to 20-next
pieh a8de33c
chore(demo): ensure min supported node version
pieh d023e2a
chore: manual migration of app.config.server.ts
pieh 074bc3c
Merge remote-tracking branch 'origin/main' into chore/try-20
pieh f931f0b
chore: bump
pieh 498862f
chore: bump to rc.0
pieh b3f6f44
Merge remote-tracking branch 'origin/main' into chore/try-20
pieh 353e63a
chore: bump to newest rc
pieh 32181e1
Merge remote-tracking branch 'origin/main' into chore/try-20
pieh c98527c
test: add 20-rc fixtures
pieh d308467
fix: add angular-20 server.ts signature
pieh 9f2ffc7
fix: handle case of outputPath not being explicitly defined
pieh 7fb6080
chore: remove outputPath from demo's angular.json to follow newly sca…
pieh 0c284ee
fix: nx handling
pieh 1f18438
test: install new fixtures deps
pieh c7cdd32
chore: skip angular@20 on not supported node versions
pieh 581d156
chore: bump node18 version a bit to match node18 compatible angular m…
pieh 23ebfa0
chore: add node22 to test matrix
pieh 2e80a23
chore: don't suggest common engine for Angular 20
pieh 9a50e78
docs: refresh readme for Angular 20
pieh 9463872
chore: bump min to 20.19
pieh dea254f
fix: add link to repo readme for more details
pieh e154ae0
chore: upgrade demo and recreate angular-20 fixtures using most recen…
pieh 189b651
Merge remote-tracking branch 'origin/main' into chore/try-20
pieh f650742
chore: sync lock files
pieh 22d7905
Merge branch 'main' into chore/try-20
pieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,28 @@ | ||
| import assert from 'node:assert' | ||
| import { versions } from 'node:process' | ||
| import { test } from 'node:test' | ||
|
|
||
| test('edge function config', async () => { | ||
| const { config } = await import('./demo/.netlify/edge-functions/angular-ssr/angular-ssr.mjs') | ||
| import { satisfies } from 'semver' | ||
|
|
||
| const excludedPathsWithMaskedHashes = config.excludedPath.map((path) => path.replace(/-[A-Z\d]{8}\./, '-HASHHASH.')) | ||
| test( | ||
| 'edge function config', | ||
| { | ||
| skip: !satisfies(versions.node, '>=20.11'), | ||
| }, | ||
| async () => { | ||
| const { config } = await import('./demo/.netlify/edge-functions/angular-ssr/angular-ssr.mjs') | ||
|
|
||
| assert.deepEqual(excludedPathsWithMaskedHashes, [ | ||
| '/.netlify/*', | ||
| '/favicon.ico', | ||
| '/heroes/index.html', | ||
| '/index.csr.html', | ||
| '/main-HASHHASH.js', | ||
| '/polyfills-HASHHASH.js', | ||
| '/styles-HASHHASH.css', | ||
| '/heroes', | ||
| ]) | ||
| }) | ||
| const excludedPathsWithMaskedHashes = config.excludedPath.map((path) => path.replace(/-[A-Z\d]{8}\./, '-HASHHASH.')) | ||
|
|
||
| assert.deepEqual(excludedPathsWithMaskedHashes, [ | ||
| '/.netlify/*', | ||
| '/favicon.ico', | ||
| '/heroes/index.html', | ||
| '/index.csr.html', | ||
| '/main-HASHHASH.js', | ||
| '/polyfills-HASHHASH.js', | ||
| '/styles-HASHHASH.css', | ||
| '/heroes', | ||
| ]) | ||
| }, | ||
| ) |
serhalp marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 20.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://github.com/netlify/angular-runtime/actions/runs/15134325612/job/42542439173#step:6:1422 - this is just to get rid of that warning for pre-angular-20 fixtures (it requires adjustment to required checks)