fix(deps): unpin all dependencies#8171
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates dependency version management by relaxing root package.json version specifiers from exact pins to semver ranges (predominantly Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This would need to happen in the other netlify packages too. It's clear that the duplicate packages increase by a lot... But assuming you guys really want to reduce your deps tree, this is a must change. Next, you'd need to start finding other places that deps need deduplication. v25.0.0 has ~100 duplicate packages. With this PR the number will increase, as it seems. Remember, updating deps blindly to the latest version, is not the right approach all the time, if one cares about the deps tree/count. Unless you can do it across all your dependencies, which isn't realistic... Just my 2 cents as a netlify-cli user who has reported the issue for years :) That is exactly the reason why I started contributing to dependents (precinct dependency, etc) packages in the first place. |
We were pinning deps to partially mimic the published npm-shrinkwrap.json for package managers like yarn and pnpm that don't support it. Since we stopped shipping the shrinkwrap in #8163, the pinning is no longer relevant. This will help users' dependency trees get deduped much further.
For the record, this is somewhat misleading. Actual users will see a decrease in count and size. We're seeing an increase due to our own package-lock and the fact that I tried to keep the scope of change in this PR limited (we can follow up to do a deep upgrade of our dep tree in this repo). |
Summary
We were pinning deps to partially mimic the published npm-shrinkwrap.json for package managers like yarn and pnpm that don't support it.
Since we stopped shipping the shrinkwrap in #8163, the pinning is no longer relevant.
This will help users' dependency trees get deduped much further.