This repository was archived by the owner on Sep 12, 2019. It is now read-only.
Add svelte and sapper to list of detectors #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinbate
reviewed
Jun 17, 2019
| env: { ...process.env }, | ||
| possibleArgsArrs, | ||
| urlRegexp: new RegExp(`(http://)([^:]+:)${5000}(/)?`, "g"), | ||
| dist: "dist" |
There was a problem hiding this comment.
I know this PR is merged already, but I was just wondering about the choice of dist here. The default Svelte template uses a public folder for its static output.
There was a problem hiding this comment.
i'm not that familiar with svelte, i didnt really check it. i have never liked the choice of dist as the keyword, as we dont care about output, we just care about the location of the _redirects file if it exists. this is a problem we'll have to fix at source
There was a problem hiding this comment.
Thanks for looking at this. The sapper location would be static which you updated correctly, but the Svelte default is public.
| // REQUIRED DEPS | ||
| if (!hasRequiredDeps(["svelte"])) return false; | ||
|
|
||
| /** everything below now assumes that we are within vue */ |
There was a problem hiding this comment.
Pedantic copy/paste leftover in comment. :)
| } | ||
|
|
||
| return { | ||
| type: "vue-cli", |
| env: { ...process.env }, | ||
| possibleArgsArrs, | ||
| urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, "g"), | ||
| dist: "dist" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Now that Svelte 3 is out, we should support svelte projects on Netlify Dev
- Test plan
Run an example svelte project.
Sapper:
Svelte:
- Description for the changelog
Adds Svelte and Sapper to list of detectors
- A picture of a cute animal (not mandatory but encouraged)
