Skip to content

refactor: change masterKey to primaryKey #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2022
Merged

refactor: change masterKey to primaryKey #2

merged 3 commits into from
Oct 22, 2022

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Oct 22, 2022

New Pull Request Checklist

Issue Description

The parse-platform doesn't use inclusive language. Though a change has been requested for 2+ years a number of times:

changes have still not been made.

Approach

Change masterKey to primaryKey to reflect inclusive language discussed in https://github.com/dialpad/inclusive-language#motivation

TODOs before merging

  • Verify tests still build
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #2 (95a9560) into main (b9de57c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   90.34%   90.39%   +0.04%     
==========================================
  Files         161      161              
  Lines       16267    16319      +52     
==========================================
+ Hits        14697    14752      +55     
+ Misses       1570     1567       -3     
Impacted Files Coverage Δ
...urces/ParseSwift/Objects/ParsePushStatusable.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseFile+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseFile+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParsePush+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParsePush+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParsePushStatus.swift 95.45% <ø> (ø)
Sources/ParseSwift/Types/ParseSchema+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseSchema+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/Query+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/Query+combine.swift 100.00% <ø> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 66aafe4 into main Oct 22, 2022
@cbaker6 cbaker6 deleted the primaryKey branch October 22, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants