Skip to content

Only use KeyManagerFactory in SniClientTest when supported by OpenSSL… #8289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

normanmaurer
Copy link
Member

… version.

Motivation:

6ed7c6c added a test which blindly assumed we can use a KeyManagerFactory all the time. This is only true if have OpenSSL 1.0.2 or later, which may not be the case.

Modifications:

Only use KeyManagerFactory in test if the OpenSSL version does support it.

Result:

More robust tests.

… version.

Motivation:

6ed7c6c added a test which blindly assumed we can use a KeyManagerFactory all the time. This is only true if have OpenSSL 1.0.2 or later, which may not be the case.

Modifications:

Only use KeyManagerFactory in test if the OpenSSL version does support it.

Result:

More robust tests.
@normanmaurer
Copy link
Member Author

I will just pull this in once the CI pass to make it happy again and its a test-case change only as well.

@normanmaurer normanmaurer merged commit 2b1514e into 4.1 Sep 14, 2018
@normanmaurer normanmaurer deleted the only_use_keymanagerfactory_when_supported branch September 14, 2018 17:03
@normanmaurer normanmaurer added this to the 4.1.30.Final milestone Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant