Fix SelectableChannel support in NioEventLoop #8344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jvirtanen
force-pushed
the
register_unwrapped_selector
branch
from
35b7157 to
80981e1
Compare
johnou
suggested changes
Oct 7, 2018
| } | ||
| }); | ||
|
|
||
| latch.await(); |
There was a problem hiding this comment.
That could be done, but please note that I set a timeout on the @Test annotation so that the whole test case will fail in case of a timeout.
normanmaurer
requested changes
Oct 7, 2018
|
|
||
| latch.await(); | ||
| } finally { | ||
| group.shutdownGracefully(); |
There was a problem hiding this comment.
Good catch! Fixed.
Motivation:
Unless the 'io.netty.noKeySetOptimization' system property is set,
registering a SelectableChannel instance to a NioEventLoop results
in a ClassCastException:
io.netty.channel.nio.SelectedSelectionKeySetSelector cannot be cast
to java.nio.channels.spi.AbstractSelector
Modifications:
Instead of 'selector', pass 'unwrappedSelector' to SelectableChannel.
Result:
It is possible to register a SelectableChannel instance without
setting the 'io.netty.noKeySetOptimization' system property.
jvirtanen
force-pushed
the
register_unwrapped_selector
branch
from
80981e1 to
243b904
Compare
|
@normanmaurer We just signed the CCLA. |
normanmaurer
approved these changes
Oct 9, 2018
|
@jvirtanen merged... thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unless the
io.netty.noKeySetOptimizationsystem property is set, registering a SelectableChannel instance to a NioEventLoop results in a ClassCastException:Modifications:
Instead of
selector, passunwrappedSelectorto SelectableChannel.Result:
It is possible to register a SelectableChannel instance without setting the
io.netty.noKeySetOptimizationsystem property.