Added exampleSetFlag to nonValidationKeyword#435
Merged
stevehu merged 1 commit intonetworknt:masterfrom Aug 18, 2021
Merged
Conversation
Contributor
|
This is a temp solution to compensating a bug from the swagger. And it might be removed in the future as the exampleSetFlag is not a JSON Schema keyword. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When using vertx, there is a keyword
exampleSetFlagpresent in swagger which is transitive dependency of vertx . So when we run the verticle we get a warning like this :-<onMetaSchema:338> [oop-thread-1] Unknown keyword exampleSetFlag - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeywordPR purpose :-
It adds the variable
exampleSetFlagto the nonValidationKeyword in V4 since the OpenApiv3 use the Json schema v4 -->private static final JsonMetaSchema META_SCHEMA = JsonMetaSchema.builder(JsonMetaSchema.getV4().getUri(), JsonMetaSchema.getV4()).addKeyword(new NonValidationKeyword("example")).build();