Merged
Conversation
stevehu
approved these changes
Mar 27, 2022
Contributor
|
@Sahil3198 Thanks a lot for your help. I didn't realize that we have the validationContext in almost all the validators as it was introduced for only one or two validators in the beginning and almost every validator is using it these days. It makes perfect sense to move to the BaseJsonValidator. Also, extracting the different versions of the implementation paves the road for use to support new versions easily. |
|
Release 1.0.68 introduced a nasty memory leak. There were only a couple of significant PRs included in that release, and this was one of them. See #546 for details. I'm not really sure how this PR could have triggered it, but thought I'd mention the problem. |
|
Ah, actually my git bisect points to this commit 5007242 as the cause. |
This was referenced May 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I made some changes to the code to improve code readability.
I used some refactoring Techniques such as Extract Method, Rename variable, Pull-up variable, Extract class, Replace conditional with polymorphism, and Push-down method.