removed unnecessary check which causes nullable=true, handleNullableFields= true with value=null to fail in all cases except OneOf#554
Conversation
|
@harishvashistha Thanks for your PR. I have run the test cases and they all passed from your branch. I cannot remember why we checked the complex validator in the first place but I guess there was a reason for that. I am wondering if we should handle the NULL for all validators or only a limited set of validators. |
|
@stevehu Great, It would be great if we can get the suitable changes in official release of this library, we are eagerly waiting for this solution. Your help would be highly appreciated in our team. |
|
@stevehu @prashanthjos should I merge this PR into another PR that is open #555 , which I created for another issue #553 ? We need code changes of both the PRs, this as well as #555 , in your master library at the same time so that we can plan our product release bug free. |
|
No worry. We are looking at both PRs together. Thanks. |
|
@SiemelNaran @stevehu @prashanthjos can we get these changes in master release please. This PR is urgently required with PR #555 as we are planning a relase on Tuesday. |
|
@prashanthjos You are requested to please approve and merge this PR and if there are some review comments I can try to add and fix those quickly. This is the highest priority thing I am stuck with in my project. |
when nullable = true , handlenullableFields = true and value supplied = null , then getting this failure message
"null found, string expected"for this example:Data to be created:
Reason appears this unnecessary check for
state.isComplexValidator()which is true only in case of oneOf . so it suppresses all handleNullableFields configurations causing the above error message.This is related to my latest query on this issue #183