-
-
Notifications
You must be signed in to change notification settings - Fork 35
Add should_run policy for when nodes is None
#141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c2f94eb
added should_run to run when nodes is None
akshitasure12 578ac32
Merge branch 'main' into fix-for-137
dschult 20243d3
Merge conflicts in nx_parallel/tests/test_should_run.py
dschult 1ddd33f
improve wording
akshitasure12 5bbfd45
remove handling for nodes is not None case
akshitasure12 fc85411
revert to including case: node is not none
akshitasure12 7197673
Merge branch 'main' into fix-for-137
dschult 975b8de
whitespace
dschult 6028273
Merge remote-tracking branch 'origin/main' into fix-for-137
akshitasure12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a consistent and organized test structure, it would be good to split the tests in this file-- tests that test
should_runused in nx-parallel can remain in this file, while tests that test the functionality implemented inshould_run_policies.py(i.e. tests with dummy functions, data, etc.) can live inutils/tests/test_should_run_policies.py. (likeget_chunks)