sync edge bc scaling logic and rescale helpers with networkx#143
Merged
sync edge bc scaling logic and rescale helpers with networkx#143
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the edge betweenness centrality scaling logic with NetworkX by consolidating rescale helpers and updating parameter handling. The changes align with NetworkX PR #8256.
- Replaces
_rescale_ewith unified_rescalefunction for both node and edge betweenness centrality - Updates parameter handling to use conditional
sampled_nodesassignment instead of passingkdirectly - Updates documentation URLs to reflect new line numbers after import reorganization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nx_parallel/algorithms/centrality/betweenness.py | Consolidates rescaling logic by using _rescale for both node and edge betweenness, updates parameter handling for sampled nodes |
| _nx_parallel/init.py | Updates documentation URLs to reflect new line numbers after code changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref. PR networkx/networkx#8256