Skip to content

sync edge bc scaling logic and rescale helpers with networkx#143

Merged
dschult merged 2 commits intomainfrom
rescale_fix
Oct 18, 2025
Merged

sync edge bc scaling logic and rescale helpers with networkx#143
dschult merged 2 commits intomainfrom
rescale_fix

Conversation

@Schefflera-Arboricola
Copy link
Member

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the edge betweenness centrality scaling logic with NetworkX by consolidating rescale helpers and updating parameter handling. The changes align with NetworkX PR #8256.

  • Replaces _rescale_e with unified _rescale function for both node and edge betweenness centrality
  • Updates parameter handling to use conditional sampled_nodes assignment instead of passing k directly
  • Updates documentation URLs to reflect new line numbers after import reorganization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
nx_parallel/algorithms/centrality/betweenness.py Consolidates rescaling logic by using _rescale for both node and edge betweenness, updates parameter handling for sampled nodes
_nx_parallel/init.py Updates documentation URLs to reflect new line numbers after code changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dschult dschult merged commit 4115c22 into main Oct 18, 2025
9 checks passed
@dschult dschult deleted the rescale_fix branch October 18, 2025 18:25
@dschult dschult added this to the 0.4 milestone Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Bug fix Something isn't working type: Maintenance

Development

Successfully merging this pull request may close these issues.

3 participants