Skip to content

MAINT : added default_benchmark_timeout to asv.conf.json#43

Merged
dschult merged 2 commits intonetworkx:mainfrom
Schefflera-Arboricola:asv_timeout
Feb 6, 2024
Merged

MAINT : added default_benchmark_timeout to asv.conf.json#43
dschult merged 2 commits intonetworkx:mainfrom
Schefflera-Arboricola:asv_timeout

Conversation

@Schefflera-Arboricola
Copy link
Member

For 800 node graphs, the benchmarks fail and give a timeout error(60.0 s).

@dschult
Copy link
Member

dschult commented Feb 6, 2024

I couldn't find default_benchmark_timeout in the docs for asv.
Where did you find that? it's a nice thing to be able to set. :)

@Schefflera-Arboricola
Copy link
Member Author

I couldn't find default_benchmark_timeout in the docs for asv.
Where did you find that? it's a nice thing to be able to set. :)

here airspeed-velocity/asv#1308
Also after increasing the default timeout here #42 i was no longer getting the timeout error.

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.
I make a comment below, but it doesn't need to be changed here unless you want to.

Co-authored-by: Dan Schult <dschult@colgate.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants