Merged
Conversation
Schefflera-Arboricola
changed the title
Schefflera-Arboricola
changed the title
Member
|
Can you edit the OP in this PR to describe what this does now and how it relates to #67? |
dschult
approved these changes
Jun 25, 2024
Member
dschult
left a comment
dschult
left a comment
There was a problem hiding this comment.
This looks good to me!
Thanks @Schefflera-Arboricola !
10 tasks
Member
|
Let's go ahead and merge this -- we can update further if other issues arise. |
rossbar
reviewed
Jul 1, 2024
Collaborator
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
Sorry for tardiness, but this LGTM!
eriknw
reviewed
Jul 3, 2024
Comment on lines
+61
to
+71
| packages = [ | ||
| 'nx_parallel', | ||
| '_nx_parallel', | ||
| 'nx_parallel.algorithms', | ||
| 'nx_parallel.algorithms.approximation', | ||
| 'nx_parallel.algorithms.bipartite', | ||
| 'nx_parallel.algorithms.centrality', | ||
| 'nx_parallel.algorithms.connectivity', | ||
| 'nx_parallel.algorithms.shortest_paths', | ||
| 'nx_parallel.utils', | ||
| ] |
There was a problem hiding this comment.
(sorry for commenting on a PR that's already merged)
It might be simpler and more maintainable to use [tool.setuptools.packages.find]. For example
[tool.setuptools.packages.find]
include = [
"nx_parallel",
"nx_parallel.*",
"_nx_parallel",
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
origin PR #67 (Now, PR#67 is for adding additional linting settings in the future)
This PR switches the nx-parallel's building tool from
hatchlingtosetuptoolsas it is more widely used and it's better for bigger projects and we need to explicitly mention all the packages(unlike hatchling) so that ensures that all packages are being built.pre-file-ignores under tool.ruff.lint section due to the following warning: