Quick fixes for BoxSearch xr() when exploring MultiModel #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 94.99% 95.00%
=======================================
Files 50 50
Lines 4355 4358 +3
=======================================
+ Hits 4137 4140 +3
Misses 218 218
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jajcayn
force-pushed
the
fix/multimodel_exploration
branch
from
9ce4375 to
98d17e8
Compare
jajcayn
force-pushed
the
fix/multimodel_exploration
branch
from
98d17e8 to
27a2d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate bugs in
xr()function ofBoxSearchwhen usingMultiModeland star parameters:xr.combine_by_coordsfails with a cryptic error, found this (combine_by_coords fails with DataArrays pydata/xarray#3248 (comment)) and it seems that this might happen when combining DataArrays, but shouldn't happen on DatasetsParameterSpaceforMultiModelmight contain stars. but not necessarily, and line 533 was giving problems when exploring over a parameter without a star... now explicitly checking for thisxarrayis fine with whatever, but when saving to netcdf,*,|are not permitted