Skip to content

Try to fix coverage for share/lib/python/neuron #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jul 15, 2025

Possible fix for #2836.

Also added coverage for the NMODL Python module (mostly ode.py).

Copy link

✔️ 54faf9c -> Azure artifacts URL

Copy link
Contributor

✔️ 54faf9c -> artifacts URL

Copy link
Contributor

✔️ ffed84f -> artifacts URL

Copy link

✔️ ffed84f -> Azure artifacts URL

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (95bd396) to head (065b762).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3530      +/-   ##
==========================================
+ Coverage   68.44%   68.86%   +0.41%     
==========================================
  Files         683      683              
  Lines      116611   116611              
==========================================
+ Hits        79818    80301     +483     
+ Misses      36793    36310     -483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Contributor

✔️ 065b762 -> artifacts URL

Copy link

✔️ 065b762 -> Azure artifacts URL

@JCGoran JCGoran linked an issue Jul 15, 2025 that may be closed by this pull request
@JCGoran JCGoran marked this pull request as ready for review July 15, 2025 17:08
@JCGoran JCGoran requested a review from nrnhines July 15, 2025 17:08
@JCGoran JCGoran requested a review from ramcdougal July 17, 2025 11:50
@ramcdougal
Copy link
Member

I don't honestly understand the testing process well enough to asssess this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: share/lib/python/neuron/tests/ are not included in coverage
2 participants