Skip to content

Fix cross wheel-building on ARM-based MacOS #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jul 17, 2025

* Add special case when building Linux NEURON wheels on ARM MacOS host
* Fix #3535
* Pass `NRN_ENABLE_INTERVIEWS` env var to container
Copy link

Copy link

✔️ 6df8909 -> Azure artifacts URL

Copy link
Contributor

✔️ 6df8909 -> artifacts URL

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (3b1cd44) to head (6df8909).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
- Coverage   68.45%   68.45%   -0.01%     
==========================================
  Files         683      683              
  Lines      116617   116617              
==========================================
- Hits        79835    79829       -6     
- Misses      36782    36788       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JCGoran JCGoran marked this pull request as ready for review July 17, 2025 20:27
@JCGoran JCGoran requested review from ramcdougal and mgeplf July 18, 2025 08:05
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine w/ me.

@JCGoran JCGoran merged commit 43a1032 into master Jul 22, 2025
43 checks passed
@JCGoran JCGoran deleted the jelic/fix_cross_build branch July 22, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_wheels.bash script cannot cross-compile on ARM-based MacOS host due to mismatched output of uname -m
2 participants