Skip to content

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Sep 22, 2025

This PR does a couple of things:

  • fixes the build so NEURON compiles and runs under NVHPC
  • modifies the tests so that some have more relaxed accuracy thresholds on NVHPC, while others are disabled (notably, the LFP test segfaults)
  • adds a CI that runs on a custom runner, which has the necessary software and hardware to build and run NEURON under NVHPC (i.e. with GPU capabilities). The underlying runner is a Ubuntu 24.04 LTS container with an NVIDIA GPU.

With the above, as long as the custom runner is available, we will always be certain that NEURON successfully builds and runs with its GPU features enabled.

Note that the documentation detailing how to setup the runner is available in this repo (only accessible to org members).

@JCGoran JCGoran added CI Continuous Integration gpu labels Sep 22, 2025
Copy link

✔️ 02e96d0 -> Azure artifacts URL

Copy link
Contributor

✔️ b315bcb -> artifacts URL

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.55%. Comparing base (81b99c0) to head (4786493).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
+ Coverage   68.52%   68.55%   +0.02%     
==========================================
  Files         686      686              
  Lines      116776   116779       +3     
==========================================
+ Hits        80018    80053      +35     
+ Misses      36758    36726      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

✔️ 4786493 -> Azure artifacts URL

Copy link
Contributor

✔️ 02e96d0 -> artifacts URL

Copy link
Contributor

✔️ 4786493 -> artifacts URL

@JCGoran JCGoran marked this pull request as ready for review September 23, 2025 06:47
@JCGoran JCGoran requested a review from nrnhines September 23, 2025 06:47
@JCGoran JCGoran merged commit c8138a8 into master Sep 23, 2025
50 checks passed
@JCGoran JCGoran deleted the jelic/fix_gpu_build branch September 23, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants