Add inline comment to git_filter_repo.py#671
Open
newfadel wants to merge 1 commit into
Open
Conversation
newren
requested changes
Jun 24, 2025
Owner
newren
left a comment
newren
left a comment
There was a problem hiding this comment.
git_filter_repo.py should remain a symlink; any changes should be made to git_filter_repo.
newren
requested changes
Jun 24, 2025
| date_format_permissive = True | ||
|
|
||
| # This program filters git repositories similar to git filter-branch, BFG repo cleaner, and others, by using a fast-export | filter | fast-import pipeline. It can also be used as a library for more complex filtering. |
Owner
There was a problem hiding this comment.
This is the wrong place to add such a comment; it appears to be a comment on the gettext_poison function, when it is intended as a comment on the script itself. Such a comment belongs at the top of the file, although, if you'll notice, the top of this file already has such a comment, so I don't see why you'd think another is necessary. Why'd you add this?
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an inline comment to git_filter_repo.py to improve code clarity.
Added an inline comment to
git_filter_repo.pyto clarify its purpose, improving readability. 😊