Step1 - 볼링 점수판(그리기) 리뷰 요청드립니다. #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boorownie
approved these changes
Jul 19, 2019
| } | ||
| Frame bowledFrame = currentFrame().fillFrame(fallenPins); | ||
|
|
||
| if (bowledFrame.getIndex().isSameIndex(currentFrame().getIndex())) { |
There was a problem hiding this comment.
List frames 의 일급컬렉션을 만들어 if분의 분기를 일급컬렉션으로 분리해보면 좋을 것 같습니다 :)
| if (bowledFrame.getIndex().isSameIndex(currentFrame().getIndex())) { | ||
| frames.set(lastFrameIndex(), bowledFrame); | ||
| } | ||
| if (!bowledFrame.getIndex().isSameIndex(currentFrame().getIndex())) { |
There was a problem hiding this comment.
규칙 4: 한 줄에 점을 하나만 찍는다.
Frame에서 Index를 꺼내와서 비교하는 로직이네요~
꺼내와서 처리하는 방법보다 직접 처리하는 메서드를 가지는 방법으로 구현해보세요 :)
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| public class BowlingGame { |
There was a problem hiding this comment.
BowlingGame에 대한 단위 테스트가 있으면 좋을 것 같아요 :)
| private static final String SPARE_SYMBOL = "/"; | ||
|
|
||
| private Pins firstFallenPins; | ||
| private Pins secondFallenPins; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요ㅎㅎ
마지막 수업에서 같은 테이블이었는데 자리가 멀어 거의 대화를 나누지 못해 아쉬웠습니다..ㅠ
최대한 TDD로 작성하려고 노력했지만.. 지우고 작성하고를 반복했기 때문에 문제가 많을 것으로 예상됩니다..!!
기능적으로는 잘 동작하는 것으로 여겨지는데
OutputView에서 출력되는 모양새를 아직 제대로 잡지 않았습니다.. (프레임 결과에 상관없이 너비가 고정된 상태)
화면 출력은 급한 불만 끈 상태라 다른 부분들 먼저 봐주시면 감사하겠습니다..!!
혹시나 커밋 메세지를 보신다면,
NoramlFrame, FinalFrame 삭제이 커밋메세지 이후부터 보시면 됩니다.바쁘시겠지만 많은 지적과 조언 부탁드리겠습니다..!! 👍 👍