Skip to content

[Step1] 코틀린DSL #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[Step1] 코틀린DSL #722

merged 2 commits into from
Nov 28, 2024

Conversation

devtaebong
Copy link

@devtaebong devtaebong commented Nov 26, 2024

안녕하세요!
코틀린 DSL 문법이 생소하면서 재미있는것 같습니다.
블랙잭 미션 잘 부탁 드립니다🙇‍♂️

Copy link
Member

@Hyeon9mak Hyeon9mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 태현님! 블랙잭 미션을 리뷰를 맡은 최현구입니다 🙇‍♂️
1단계 잘 진행해주셨습니다! 다음 단계 진행을 위해 바로 approve 하겠습니다.
간단한 코멘트만 확인해주세요~

Comment on lines +81 to +86
class PersonBuilder {
private lateinit var name: String
private var company: String? = null
private val skills = mutableListOf<String>()
private val languages = mutableListOf<Language>()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생성자를 통해 기본 값을 할당해준다면 테스트 코드 작성이 훨씬 편리해지겠네요 😄

Comment on lines +87 to +92
fun name(value: String) {
name = value
}

fun company(value: String) {
company = value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name 를 초기화 해주지 않고 빌드가 진행되면 어떤 일이 발생할까요?

@Hyeon9mak Hyeon9mak merged commit 95bfe0e into next-step:devtaebong Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants