use var PHP_OPCACHE_MEMORY_CONSUMPTION for configuration #2090
Conversation
Signed-off-by: Thomas Clavier <[email protected]>
Signed-off-by: Thomas Clavier <[email protected]>
|
I think maybe using "sed" to change original files? |
|
using |
Sorry, That all version was build by template files, your code is right. |
|
This requires some documentation in the README. |
Dockerfile-alpine.template
Outdated
| echo 'opcache.interned_strings_buffer=32'; \ | ||
| echo 'opcache.max_accelerated_files=10000'; \ | ||
| echo 'opcache.memory_consumption=128'; \ | ||
| echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \ |
There was a problem hiding this comment.
| echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \ | |
| echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMPTION}'; \ |
Dockerfile-debian.template
Outdated
| echo 'opcache.interned_strings_buffer=32'; \ | ||
| echo 'opcache.max_accelerated_files=10000'; \ | ||
| echo 'opcache.memory_consumption=128'; \ | ||
| echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \ |
There was a problem hiding this comment.
| echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \ | |
| echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMPTION}'; \ |
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
If we're going to support opcache changes like this, we should probably also support opcache.max_accelerated_files and opcache.interned_strings_buffer since they're all part of the same setup checks in Server. Otherwise it'll be an incomplete enhancement.
joshtrichards
changed the title
|
See also #2185 (comment) |
Dockerfile-debian.template
Outdated
| # see https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html | ||
| ENV PHP_MEMORY_LIMIT 512M | ||
| ENV PHP_UPLOAD_LIMIT 512M | ||
| ENV PHP_OPCACHE_MEMORY_CONSUMTION 128 |
There was a problem hiding this comment.
| ENV PHP_OPCACHE_MEMORY_CONSUMTION 128 | |
| ENV PHP_OPCACHE_MEMORY_CONSUMPTION 128 |
Dockerfile-alpine.template
Outdated
| # see https://docs.nextcloud.com/server/latest/admin_manual/installation/server_tuning.html#enable-php-opcache | ||
| ENV PHP_MEMORY_LIMIT 512M | ||
| ENV PHP_UPLOAD_LIMIT 512M | ||
| ENV PHP_OPCACHE_MEMORY_CONSUMTION 128 |
There was a problem hiding this comment.
| ENV PHP_OPCACHE_MEMORY_CONSUMTION 128 | |
| ENV PHP_OPCACHE_MEMORY_CONSUMPTION 128 |
|
This is a common request downstream in nextcloud/helm. If this PR was re-submitted with the suggested fixes here, would it still be viable? I see there was conversation #2185, but I can't tell if that means this PR should be closed? |
|
Is it only about the |
|
see also #2275 |
|
@tclavier are you still working on this? |
|
I guess I didn't understand what was missing for this PR to be accepted. |
|
It requires documentation in README |
|
I thinks all is OK, who can merge this PR ? |
5 participants
No description provided.