Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .examples/dockerfiles/full/apache/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@ RUN set -ex; \
apt-get install -y --no-install-recommends \
ffmpeg \
ghostscript \
libmagickcore-6.q16-6-extra \
libmagickcore-7.q16-10-extra \
procps \
smbclient \
supervisor \
lsb-release \
ca-certificates \
curl \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not required as runtime dependencies. And already included in the base image anyway.

# libreoffice \
; \
rm -rf /var/lib/apt/lists/*
Expand All @@ -18,6 +21,10 @@ RUN set -ex; \
\
savedAptMark="$(apt-mark showmanual)"; \
\
curl -sSLo /tmp/debsuryorg-archive-keyring.deb https://packages.sury.org/debsuryorg-archive-keyring.deb; \
dpkg -i /tmp/debsuryorg-archive-keyring.deb; \
sh -c 'echo "deb [signed-by=/usr/share/keyrings/debsuryorg-archive-keyring.gpg] https://packages.sury.org/php/ $(lsb_release -sc) main" > /etc/apt/sources.list.d/php.list'; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo does not provide libc-client-dev.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove imap from the example then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then how would we get imap working?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think I see how https://stackoverflow.com/a/79444588

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More info php/pecl-mail-imap#3

Looks like Nextcloud will need to support a different imap extension like alpine-imap or https://github.com/barbushin/php-imap

\
apt-get update; \
apt-get install -y --no-install-recommends \
libbz2-dev \
Expand Down