feat(nextcloud): Add support for AWS session token key #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new configuration option for S3 sessionTokenKey. - Updated template and values to enable usage of this key Signed-off-by: Hector Valcarcel <[email protected]>
Signed-off-by: Hector Manuel <[email protected]>
wrenix
requested changes
Mar 6, 2025
Collaborator
wrenix
left a comment
wrenix
left a comment
There was a problem hiding this comment.
TODOs
- please add the same lines from nextcloud/docker#2364 also here: files/defaultConfigs/s3.config.php.tpl
- If we are clear with it you have to bump the chart version
- point we have to wait for a new release of the server:
- in v30 current supported version of that helm-chart
- in v31 current stable version of server
wrenix
changed the title
wrenix
added
S3
Signed-off-by: Hector Valcarcel <[email protected]>
…into feat/support-aws-session-token
Author
|
@wrenix I'm sorry it took me so long to make the requested changes, somehow I completely overlooked your comment 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
tokens comes from temporal credentials, more likely secrets auto-generated from sts assume role, etc. Therefore
it only makes sense to reference it from an "existing secret"
Checklist
Chart.yamlaccording to semver.