Skip to content

fix cellranger filename check#261

Merged
grst merged 3 commits intodevfrom
fix-cellranger-filename-check
Aug 24, 2023
Merged

fix cellranger filename check#261
grst merged 3 commits intodevfrom
fix-cellranger-filename-check

Conversation

@grst
Copy link
Copy Markdown
Member

@grst grst commented Aug 24, 2023

  • bump version to 2.5.0dev
  • Update cellranger module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@grst grst requested a review from vjmarteau August 24, 2023 12:15
@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@grst grst changed the base branch from master to dev August 24, 2023 12:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 24, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0bf2013

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#
Details

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-24 12:18:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants