Skip to content

Add check_max to AlevinQC time limit#335

Merged
grst merged 1 commit intodevfrom
fix-334
May 29, 2024
Merged

Add check_max to AlevinQC time limit#335
grst merged 1 commit intodevfrom
fix-334

Conversation

@nictru
Copy link
Copy Markdown
Contributor

@nictru nictru commented May 29, 2024

This solves #334.

We could add task.attempt as a factor here, but I don't know if this is desirable since 120.h is quite long already.

@nictru nictru added the bug Something isn't working label May 29, 2024
@nictru nictru requested a review from grst May 29, 2024 12:44
@nictru nictru self-assigned this May 29, 2024
@nictru nictru linked an issue May 29, 2024 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 29, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit da41396

+| ✅ 203 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.6.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-29 12:45:51

Copy link
Copy Markdown
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grst grst enabled auto-merge May 29, 2024 12:47
@grst grst merged commit a4efbde into dev May 29, 2024
@grst grst deleted the fix-334 branch May 29, 2024 12:57
@grst grst mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time limit of AlevinQC

2 participants