Skip to content

Conversation

fmalmeida
Copy link
Contributor

Depends on #484 that contains the commits required for a release that are described in the "Steps for release" section here:
https://nf-co.re/docs/checklists/pipeline_release#steps-to-release

Post steps

After merged, it is required to:

Outlined at https://nf-co.re/docs/checklists/pipeline_release

matbonfanti and others added 30 commits March 4, 2025 17:28
Change simpleaf protocol name from 10xv4 to 10xv4-3p
updated --cellranger_index docs to point out that the base index directory is needed
@fmalmeida fmalmeida requested review from apeltzer and grst August 1, 2025 13:07
@fmalmeida fmalmeida marked this pull request as draft August 1, 2025 13:07
Copy link

github-actions bot commented Aug 1, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1088423

+| ✅ 248 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗  20 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • schema_description - No description provided in schema for parameter: skip_emptydrops
  • local_component_structure - gffread_transcriptome.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - star_align.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - alevinqc.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - gtf_gene_filter.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - concat_h5ad.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - anndatar_convert.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - mtx_to_h5ad.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - parse_cellrangermulti_samplesheet.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - h5ad_conversion.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - align_cellrangerarc.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - kallisto_bustools.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - starsolo.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - simpleaf.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - fastqc.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - align_cellrangermulti.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - align_cellranger.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-08-05 07:21:57

@fmalmeida fmalmeida marked this pull request as ready for review August 4, 2025 13:32
@fmalmeida
Copy link
Contributor Author

Hi @grst ,
Added a small PR for not running conda profile:
#489

Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmalmeida fmalmeida requested a review from nictru August 5, 2025 07:27
Copy link
Contributor

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@fmalmeida
Copy link
Contributor Author

Hi @grst ,
Do you know why the full sizes are failling? Maybe is not to worry?
I ask because in last PR it seemed that they were skipped:
https://github.com/nf-core/scrnaseq/actions/runs/13765644905

@grst
Copy link
Member

grst commented Aug 11, 2025

I have no idea! I would expect full-size tests to run before release, otherwise what's the point.

@nictru, are you aware how this should be?

@nictru
Copy link
Contributor

nictru commented Aug 11, 2025

Yes they should run, but I am not too proficient with the full-size tests, so I would ask someone else for help

@grst
Copy link
Member

grst commented Aug 11, 2025

@nf-core/ops can you help finding out why the full-sized tests are not running? All I can see is a call to the seqera API that fails without an obvious error message.

@nictru
Copy link
Contributor

nictru commented Sep 2, 2025

Hey, the megatests through github actions currently don't work, and there is nothing to fix on the pipeline site. Following this thread I now have access to run the tests directly from seqera platform. Will try to get this running soon

@fmalmeida
Copy link
Contributor Author

Hi @nictru ,
Thanks for the update. Please let us know once you have updates of the runs, so we know if we can release it or not
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.