Add more fumble counters to calculate_stats()#575
Merged
Conversation
It's never counted alone, always in combination with 52 or 53. So we cannot add it to the total.
(because we were missing some edge case fumbles on offense)
4 tasks
Contributor
Member
Author
|
Variables added 
|
guga31bb
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #515
This PR:
def_fumbleswhere we counted stat ID 54 (fumble oob) as individual fumble although it's just an add on information to 52 or 53.calculate_stats()does not count all offensive fumbles #515The new fumble stats count all fumbles regardless of the unit the player was on. This means that all existing fumble stats are included here but we make sure not to loose any fumbles, esp. on offense.