Revamped options utility #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 14, 2016 23:33
Features * Added ability to override default options via linkify.options.defaults * Options that take functions with value and type arguments can now be specified as objects, where each key is the target type. For example: ``` 'github.com is #rad, please email [email protected]'.linkify({ formatHref: { email: (mailto) => `${mailto}?subject=Hello`, hashtag: (hashtag) => `https://twitter.com/hashtag/${hashtag.substr(1)}` } }); ``` Bug fixes * Allow disabling linkClass (by using default options) - Fixes #144 Deprecations * Deprecated `linkClass` option. Use `className` instead * Deprecated `linkAttributes` option. Use `attributes` instead. * The `linkified` default class name for links will no longer be provided in a future release Breaking Changes * Fully removed deprecated `newLine` option
Including improvements and fixes for QUnit tests
Note to self: IE8 is the devil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
linkify.options.defaultsBug fixes
Deprecations
linkClassoption. UseclassNameinsteadlinkAttributesoption. Useattributesinstead.linkifieddefault class name for links will no longer be provided in a future releaseBreaking Changes
newLineoption