Version 16 does not work for me

[henryruhs]

Type of Issue

[x] Bug Report
[ ] Feature Request

Description

ERROR TypeError: this.injector is undefined

How To Reproduce

1. "npm run build" in https://github.com/henryruhs/ngx-crud to create build directory
2. link ngx-crud dependency in https://github.com/henryruhs/ngx-crud-playground via npm link
3. run npm start

The playground works with ngx-crud 13.0.1 which is build with ng-packagr 15.x.x

Expected Behaviour

Well, the injector from CrudService should work.

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr:            16.0.0
@angular/compiler:     16.0.0
rollup:                3.21.1
typescript:            5.0.4

[alan-agius4]

This is expected as it's related to the ECMA2022 changes which by default class fields behave different.

You can read more about this here;

• https://www.typescriptlang.org/tsconfig#useDefineForClassFields
• https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifier

There are a couple of things you can do;

• Refactor the code.
• In the tsconfig provided to ng-packagr, set useDefineForClassFields to false.

[henryruhs]

Edit: follow the fix from #2612 (comment)

[Michsior14]

For the future readers, useDefineForClassFields: false won't help with pre-intialized class true-private fields (#) in ES2022 and TS 5.0.4 (works fine with TS 4.9.5): microsoft/TypeScript#54206.

It's also a bit unfortunate because there are no errors during compilation, but only in runtime.

[henryruhs]

I cannot confirm this @Michsior14 as it still works for me using 5.0.4.

[Michsior14]

I've edited a bit the comment above. It's about #privates, on the public/private it will work without issues even on 5.0.4.

[alan-agius4]

@Michsior14, Unfortunately that is a TypeScript bug which we cannot action. As a workaround you could downgrade TypeScript or refactor the class to not require useDefineForClassFields.

[Michsior14]

useDefineForClassFields

Yup, I am aware, just wanted to post this so others don't need to debug and just stay on 4.9.5 until it's resolved (useDefineForClassFields refactor is not easy due to microsoft/TypeScript#53286).

[github-actions]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}