Skip to content

fix: incorrect conversion between integer types #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions internal/template/reflect.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,28 @@
package template

import (
"fmt"
"log"
"math"
"reflect"
"strconv"
"strings"
)

func parseAllocateInt(desired string) (int, error) {
parsed, err := strconv.ParseInt(desired, 10, 32)
if err != nil {
return int(0), err
}
if parsed < 0 {
return int(0), fmt.Errorf("non-negative decimal number required for array/slice index, got %#v", desired)
}
if parsed <= math.MaxInt32 {
return int(parsed), nil
}
return math.MaxInt32, nil
}

func deepGetImpl(v reflect.Value, path []string) interface{} {
if !v.IsValid() {
return nil
Expand All @@ -28,15 +43,11 @@ func deepGetImpl(v reflect.Value, path []string) interface{} {
case reflect.Map:
return deepGetImpl(v.MapIndex(reflect.ValueOf(path[0])), path[1:])
case reflect.Slice, reflect.Array:
iu64, err := strconv.ParseUint(path[0], 10, 64)
i, err := parseAllocateInt(path[0])
if err != nil {
log.Printf("non-negative decimal number required for array/slice index, got %#v\n", path[0])
log.Println(err.Error())
return nil
}
if iu64 > math.MaxInt {
iu64 = math.MaxInt
}
i := int(iu64)
if i >= v.Len() {
log.Printf("index %v out of bounds", i)
return nil
Expand Down