Skip to content

Add default value nginx to ingressClassName for the virtualservers CRD #6893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add default value nginx to ingressClassName for the virtualservers CRD #6893

wants to merge 2 commits into from

Conversation

hanyouqing
Copy link
Contributor

@hanyouqing hanyouqing commented Dec 3, 2024 •
edited
Loading

Proposed changes

Fix #6891

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hanyouqing hanyouqing requested a review from a team as a code owner December 3, 2024 08:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@hanyouqing hanyouqing mentioned this pull request Dec 3, 2024
Open
@hanyouqing
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@hanyouqing
Copy link
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
NGINX Ingress Controller
Status: Todo ☑
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple NGINX Ingress Controllers doesn't work well
1 participant
@hanyouqing