Skip to content

Update Basic configuration documentation #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Mar 19, 2025

Proposed changes

This commit changes the example YAML code block to single-source the contents from the actual GitHub code. It also updates some parts of the page structure to match contemporary style conventions.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit changes the example YAML code block to single-source the
contents from the actual GitHub code. It also updates some parts of the
page structure to match contemporary style conventions.
@ADubhlaoich ADubhlaoich added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Mar 19, 2025
@ADubhlaoich ADubhlaoich self-assigned this Mar 19, 2025
@ADubhlaoich ADubhlaoich requested review from a team as code owners March 19, 2025 11:43
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7531/

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) March 19, 2025 13:04
@ADubhlaoich ADubhlaoich marked this pull request as draft March 25, 2025 16:44
auto-merge was automatically disabled March 25, 2025 16:44

Pull request was converted to draft

@ADubhlaoich
Copy link
Contributor Author

Swapped this to draft just in case someone prematurely merges it.

@ADubhlaoich ADubhlaoich marked this pull request as ready for review March 31, 2025 15:59
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) March 31, 2025 16:00
@ADubhlaoich ADubhlaoich merged commit 2885caa into main Mar 31, 2025
30 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/update-code-example branch March 31, 2025 16:01
nginx-bot pushed a commit that referenced this pull request Mar 31, 2025
This commit changes the example YAML code block to single-source the
contents from the actual GitHub code. It also updates some parts of the
page structure to match contemporary style conventions.
haywoodsh pushed a commit that referenced this pull request Apr 2, 2025
This commit changes the example YAML code block to single-source the
contents from the actual GitHub code. It also updates some parts of the
page structure to match contemporary style conventions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants