Tweak some maintenance make targets #8618
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -79,9 +79,14 @@ format: ## Run goimports & gofmt | |||||
|
|
||||||
| .PHONY: staticcheck | ||||||
| staticcheck: ## Run staticcheck linter | ||||||
| @staticcheck -version >/dev/null 2>&1 || go install honnef.co/go/tools/cmd/staticcheck@2025.1.1; | ||||||
| staticcheck ./... | ||||||
|
|
||||||
| .PHONY: govulncheck | ||||||
| govulncheck: | ||||||
|
There was a problem hiding this comment. The new govulncheck target is missing a description comment for the help system. Add '## Run govulncheck vulnerability scanner' after the target name to maintain consistency with other targets like staticcheck.
Suggested change
|
||||||
| @govulncheck -version >/dev/null 2>&1 || go install golang.org/x/vuln/cmd/[email protected]; | ||||||
|
Collaborator
There was a problem hiding this comment. Lets use renovate if we can to avoid manually needing to manage this |
||||||
| govulncheck ./... | ||||||
|
|
||||||
| .PHONY: test | ||||||
| test: ## Run GoLang tests | ||||||
| go test -tags=aws,helmunit -shuffle=on ./... | ||||||
|
|
@@ -235,7 +240,11 @@ ubi-image-nap-dos-plus: build ## Create Docker image for Ingress Controller (UBI | |||||
| --build-arg NAP_MODULES=waf,dos --build-arg NAP_WAF_VERSION=$(NAP_WAF_VERSION) --build-arg NAP_AGENT_VERSION=$(NAP_AGENT_VERSION) | ||||||
|
|
||||||
| .PHONY: all-images ## Create all the Docker images for Ingress Controller | ||||||
| all-images: | ||||||
| images="alpine-image alpine-image-plus alpine-image-plus-fips alpine-image-nap-plus-fips debian-image debian-image-plus debian-image-nap-plus debian-image-dos-plus debian-image-nap-dos-plus ubi-image ubi-image-plus ubi-image-nap-plus ubi-image-dos-plus ubi-image-nap-dos-plus"; \ | ||||||
| for img in $$images; do \ | ||||||
| TAG="$(strip $(TAG))-$$img" make $$img; \ | ||||||
| done | ||||||
|
|
||||||
| .PHONY: patch-os | ||||||
| patch-os: ## Patch supplied image | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use renovate if we can to avoid manually needing to manage this