-
Notifications
You must be signed in to change notification settings - Fork 128
Fix crash when BackendRef filter is specified #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When a BackendRef filter is specified in a Route, the control plane crashes due to an index out of range error. Solution: Fix the way we build the filter list so we don't access an undefined index.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3508 +/- ##
==========================================
+ Coverage 86.79% 86.82% +0.02%
==========================================
Files 127 127
Lines 15079 15079
Branches 62 62
==========================================
+ Hits 13088 13092 +4
+ Misses 1840 1836 -4
Partials 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
approved these changes
Jun 13, 2025
bjee19
approved these changes
Jun 13, 2025
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: When a BackendRef filter is specified in a Route, the control plane crashes due to an index out of range error. Solution: Fix the way we build the filter list so we don't access an undefined index.
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: When a BackendRef filter is specified in a Route, the control plane crashes due to an index out of range error. Solution: Fix the way we build the filter list so we don't access an undefined index.
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: When a BackendRef filter is specified in a Route, the control plane crashes due to an index out of range error. Solution: Fix the way we build the filter list so we don't access an undefined index.
sjberman
added a commit
that referenced
this pull request
Jul 2, 2025
Problem: When a BackendRef filter is specified in a Route, the control plane crashes due to an index out of range error. Solution: Fix the way we build the filter list so we don't access an undefined index.
6 tasks
sjberman
added a commit
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When a BackendRef filter is specified in a Route, the control plane crashes due to an index out of range error.
Solution: Fix the way we build the filter list so we don't access an undefined index.
Testing: Verified that the crash no longer occurs.
Closes #3507
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.