Compile .NetStandard 1.0 #3
Conversation
|
@fredericDelaporte @ngbrown can you please review? Also, I need some help with resolving TODO items in the description |
src/Iesi.Collections.sln
Outdated
| @@ -1,6 +1,6 @@ | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 15 | |||
| VisualStudioVersion = 15.0.26403.3 | |||
| VisualStudioVersion = 15.0.26430.6 | |||
| MinimumVisualStudioVersion = 10.0.40219.1 | |||
There was a problem hiding this comment.
Maybe should be change to v15, since th csproj format has been migrated to the new 2017 one.
There was a problem hiding this comment.
The problem that VS adds this back automatically
| <TargetFrameworks>netstandard1.0;net40;net461</TargetFrameworks> | ||
| <Company>NHibernate community</Company> | ||
| <Summary>Additional implementations of System.Collections.Generic.ISet<T>.</Summary> | ||
| <Description>The System.Collections namespace in the .NET Framework provides a number of collection types that are extremely useful for manipulating data in memory. However, some specialized implementations of ISet are not available. Iesi.Collections 4.0 for .Net 4.0 contains the LinkedHashSet (preserves insertion order), the ReadOnlySet and the SynchronizedSet. The latter two wrap an actual set.</Description> |
There was a problem hiding this comment.
Maybe a bit nit-picky, but there is a tab instead of a space just before the implementations word.
| <Summary>Additional implementations of System.Collections.Generic.ISet<T>.</Summary> | ||
| <Description>The System.Collections namespace in the .NET Framework provides a number of collection types that are extremely useful for manipulating data in memory. However, some specialized implementations of ISet are not available. Iesi.Collections 4.0 for .Net 4.0 contains the LinkedHashSet (preserves insertion order), the ReadOnlySet and the SynchronizedSet. The latter two wrap an actual set.</Description> | ||
| <Version>4.0.2</Version> | ||
| <AssemblyVersion>4.0.0.4000</AssemblyVersion> |
There was a problem hiding this comment.
We would probably have to change the version before releasing a new version.
There was a problem hiding this comment.
No, this should stay static as there are no breaking changes
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard1.0;net40;net461</TargetFrameworks> |
There was a problem hiding this comment.
netstandard1.3 supports [Serializable] attribute, provided we add a conditional dependency.
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
<PackageReference Include="System.Runtime.Serialization.Formatters">
<Version>4.3.0</Version>
</PackageReference>
</ItemGroup>
If we intend to keep the serialization stuff with NHibernate core, maybe should add a netstandard1.3 target with that additional dependency.
There was a problem hiding this comment.
Cool, I'll add netstandard 1.3 target
|
Does this means you achieved fixing building scripts, but for another CI provider? |
I think it still needs some work. I'll prefer to adjust the NAnt script to do the work, and run on TC. |
|
Ok, now it's almost ready. There are some stuff about versions remaining in a nant files. We are not using that version strategy. Need to decide how we are going to deal with versions going forward. But, as for now, I think this is an issue for a separate discussion. |
- Migrate to VS2017 project format - Multi-target to .NetStandard 1.0, .NetStandard 1.3, .NET 4.0 & .NET 4.6.1 resolves #2
TODO
fixes #2