Skip to content

Missing breaking change documentation (TryGetCollectionParameter) #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fubar-coder opened this issue Oct 7, 2020 · 3 comments
Closed

Comments

@fubar-coder
Copy link
Contributor

I have a custom implementation which is based on BaseHqlGeneratorForMethod. Previously, a collection parameter was automatically detected as collection, but now I have to override TryGetCollectionParameter.

This breaking change isn't documented in the 5.3.0 release notes.

@fredericDelaporte
Copy link
Member

Thanks for the report.
It will likely be fixed (documented) as part of 5.3.4 release task.
This possible breaking change comes from #2365.

@fredericDelaporte
Copy link
Member

fredericDelaporte commented Oct 7, 2020

By the way, there are not many methods which may meaningfully support parameter lists. Just to be sure we have not overlooked something, may you confirm you need to override it only for specific method generator cases, like .Contains methods?

@fubar-coder
Copy link
Contributor Author

Yes, I only had to override it for a method taking an array of GUIDs that were the last of four parameters.

fredericDelaporte added a commit to fredericDelaporte/nhibernate-core that referenced this issue Oct 29, 2020
And document a missing breaking change.
Fixes nhibernate#2578
fredericDelaporte added a commit that referenced this issue Nov 1, 2020
And document a missing breaking change.
Fixes #2578
bahusoid pushed a commit to bahusoid/nhibernate-core that referenced this issue Aug 10, 2021
And document a missing breaking change.
Fixes nhibernate#2578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants