Skip to content

Add support for out/ref Nullable parameters of proxied methods #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 27, 2017
Merged

Add support for out/ref Nullable parameters of proxied methods #1389

merged 9 commits into from
Oct 27, 2017

Conversation

pmattmann
Copy link
Contributor

@pmattmann pmattmann commented Oct 18, 2017 •
edited
Loading

Add support to out/ref Nullable parameters of proxied methods.

public class MyEntity {
  private int? _data1 = 1;
  private int? _data2 = 2;

  public virtual void GetData(out int? d1, out int? d2) {
    d1 = _data1;
    d2 = _data2;
  }
}

Pirmin Mattmann added 2 commits October 18, 2017 10:17
SaveRefArgument supports out/ref Nullable<T> parameters
069b3f2 
Add support to out/ref Nullable<T> parameters of proxied methods.

public class MyEntity {
  private int? _data1 = 1;
  private int? _data2 = 2;

  public virtual void GetData(out int? d1, out int? d2) {
    d1 = _data1;
    d2 = _data2;
  }
}
Merge branch 'master' into master
4ab88b7
@hazzik
Copy link
Member

hazzik commented Oct 24, 2017

Thanks @pmattmann. Can you please add some tests?

@hazzik hazzik added the t: Bug label Oct 24, 2017
@hazzik
Copy link
Member

hazzik commented Oct 25, 2017

Next bugfix, if tests are provided

Pirmin Mattmann added 2 commits October 27, 2017 06:14
@hazzik
Copy link
Member

hazzik commented Oct 27, 2017

ref still not supported.

@hazzik
Copy link
Member

hazzik commented Oct 27, 2017

Strange. It does not work on mono.

@hazzik
Copy link
Member

hazzik commented Oct 27, 2017

The DefaultArgumentHandler required corresponding changes to work on mono.

@hazzik hazzik changed the title SaveRefArgument supports out/ref Nullable<T> parameters Add support to out/ref Nullable parameters of proxied methods Oct 27, 2017
@hazzik hazzik changed the title Add support to out/ref Nullable parameters of proxied methods Add support for out/ref Nullable parameters of proxied methods. Oct 27, 2017
@hazzik hazzik changed the title Add support for out/ref Nullable parameters of proxied methods. Add support for out/ref Nullable parameters of proxied methods Oct 27, 2017
@hazzik hazzik merged commit 2e409d0 into nhibernate:master Oct 27, 2017
@hazzik
Copy link
Member

hazzik commented Oct 27, 2017

Thanks

@hazzik hazzik added this to the 5.0.1 milestone Oct 27, 2017
@fredericDelaporte fredericDelaporte mentioned this pull request Oct 24, 2018
Merged
fredericDelaporte added a commit to fredericDelaporte/nhibernate-core that referenced this pull request Oct 24, 2018
@fredericDelaporte
Test ref and out methods with static proxy
114a868 
Follow up to nhibernate#1451 for still testing NH-2622, NH-2628 and nhibernate#1389
@fredericDelaporte fredericDelaporte mentioned this pull request Oct 24, 2018
Merged
fredericDelaporte added a commit that referenced this pull request Oct 25, 2018
@fredericDelaporte
Test ref and out methods with static proxy
41782de 
Follow up to #1451 for still testing NH-2622, NH-2628 and #1389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: ByteCode providers r: Fixed t: Bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pmattmann @hazzik