.NET Core 2.0 and .NET Standard 2.0 support #1523

hazzik · 2018-01-11T02:21:21Z

These are minimal changes required to make a .NET Core 2.0 and .NET Standard 2.0 builds.

There are no test infrastructure yet, but all tests pass locally on windows dotnet core.

Summary of changes:

Assume that serialization of System.Type and co is a foreign concept to .NET Core 2.0 so the users required to write serialization surrogates. We might provide these in the future if we want to.
SqlClient, Odbc, Oledb drivers are converted to ReflectionBasedDriver to avoid the extra dependencies.
There are some problems loading App.config when test run from VS/dotnet test. This is a known issue in NUnit adapter/dotnet. We can avoid this issue by switching to NUnitLite to run .NET Core 2.0 tests.
CallSessionContext uses a static AsyncLocal field to mimic the CallContext behavior.
.NET Core 2.0 DriverBase indicates that System.Transaction is not supported (.NET Standard that it is supported).

hazzik · 2018-01-11T12:05:16Z

Build is failing because NAnt is trying to tell MSBuild to build the project into the same folder.

src/NHibernate.Test/App.config

src/NHibernate.Test/CfgTest/ConfigurationSchemaFixture.cs

src/NHibernate.Test/Async/TransformTests/AliasToBeanResultTransformerFixture.cs

src/NHibernate/Driver/DriverBase.cs

src/NHibernate/Linq/Functions/StringGenerator.cs

LightCZ · 2018-01-24T17:35:25Z

What is the difference between this pull request and #633 ? As i understood this one, this should be the minimal required changes but not finished and #633 have some major breaking changes also. Is that correct?

hazzik · 2018-01-24T20:52:59Z

@LightCZ pretty much. This one has minimal changes. The other one is with breaking changes. ~~Both of them lack the CI changes so builds fail.~~

fredericDelaporte · 2018-02-09T10:48:13Z

Someone steals my console?

Not me, if you were referring to the TeamCity build agent.

hazzik · 2018-02-09T10:56:37Z

hahaha, no. Check the actual commit. It seems that something is redirecting the console output so the timer did not write to it.

hazzik · 2018-02-20T20:05:55Z

I did. Builds are working now.

…

On Wed, 21 Feb 2018 at 8:28 AM, Frédéric Delaporte ***@***.***> wrote: Looking here <https://help.appveyor.com/discussions/problems/5675-all-builds-stuck-at-queued-status>, it seems we have to leave them a message for them to unblock the queue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1523 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI1l1N52sQZaGAkwUcoQUo5PmDl8yyEks5tWxzsgaJpZM4RaOcd> .

appveyor.yml

doc/NHibernate.shfbproj.template

src/NHibernate.Test/App.config

src/NHibernate.Test/DriverTest/ReflectionBasedDriverTest.cs

fredericDelaporte · 2018-02-20T13:55:50Z

src/NHibernate.Test/App.config

@@ -31,10 +31,9 @@
 			<property name="dialect">NHibernate.Dialect.MsSql2008Dialect</property>

 			<property name="connection.driver_class">NHibernate.Driver.Sql2008ClientDriver</property> <!-- Shouldn't be necessary, but is required by some tests -->
-			<property name="connection.connection_string_name">TestConnectionString</property>
+			<property name="connection.connection_string">Server=localhost\sqlexpress;Database=nhibernate;Integrated Security=SSPI</property>


This change somewhat alters the CanGetNamedConnectionStringFromConfiguration test: previously this test was testing overriding a file configured connection.connection_string_name, while now it tests that connection.connection_string_name setting takes precedence over connection.connection_string.

And this change also leaves a now unneeded TestConnectionString connection string.

It was a pre-nunitlite change, so, potentially can be reverted. I'll investigate. Probably if this will be reverted, it would be [almost] impossible to test in VS.

src/NHibernate/Cfg/Environment.cs

src/NHibernate/Context/CallSessionContext.cs

src/NHibernate/Linq/Functions/StringGenerator.cs

hazzik · 2018-02-22T02:54:18Z

@fredericDelaporte I've fixed most of the concerns, could you please take another look?

fredericDelaporte · 2018-02-22T19:31:41Z

Yes but it may take a while, I am not at home and currently spend most of my (awaken) time outside.

src/NHibernate.Test/SystemTransactions/TransactionNotificationFixture.cs

fredericDelaporte · 2018-02-24T10:15:54Z

src/NHibernate.Test/TestsContext.cs

+			System.Reflection.Assembly.GetEntryAssembly()?.GetName().Name == "testhost";
+
+		public static void AssumeSystemTypeIsSerializable() =>
+			Assume.That(typeof(System.Type).IsSerializable, Is.True);


Since Assume has a semantic implying failure on theories if a theory fail the constraint for all its cases, we likely should instead use Ignore. Otherwise using this helper in a theory will still cause it to fail, while we use it for ignoring the test.

Ok, I’ll change this to Ignore instead.

.travis.yml

appveyor.yml

src/NHibernate.Test/Async/NHSpecificTest/NH3583/AutoFlushFixture.cs

- When executing these methods on .NET Core on Linux they were failing with AccessViolationException crushing the application.

Co-authored-by: Frédéric Delaporte <[email protected]>

stevenlauwers22 · 2018-02-28T10:21:47Z

Awesome! Looking forward to the release of 5.1!

ngbrown · 2018-03-02T05:36:40Z

src/NHibernate/NHibernate.csproj

    <Reference Include="System.ServiceModel" />
    <Reference Include="System.Transactions" />
    <Reference Include="System.Configuration" />
  </ItemGroup>

+  <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.0'">


It seems that building the core library for netcoreapp2.0 is unnecessary.

Is leaving off the System.Reflection.Emit package references worth it for the increased bulk in the NuGet package?

cloviscoli · 2018-03-02T16:48:30Z

Any forecast when we will have a release?

stephan-simondshealth-com-au · 2018-03-07T20:58:12Z

I'm also hoping this will make it into a release soon. IMHO supporting a newer version of .NET Core (Even if its not fully) would justify a release. But I'm probably biased :-)
In the mean time, are there overnight NuGet package that I can pull?
(For instance: Is there an AppVeyor project feed?) Thanks !

fredericDelaporte · 2018-03-08T11:26:56Z

I'm also hoping this will make it into a release soon. IMHO supporting a newer version of .NET Core (Even if its not fully) would justify a release. But I'm probably biased :-)

So do I, but some pending PR deserve being merged in 5.1. Of course at some point those taking too long to finalize may be postponed for a later version.

In the mean time, are there overnight NuGet package that I can pull?

The CI builds include a "NHibernate (Release Package)" TeamCity build, having in its artifact NuGet packages, the binary release zip and more. Please note that they are still versioned according to latest release: we increment the version only when actually performing a release.

You can take them from master builds or from a specific PR, as you wish. Access the latest master builds from the commits page. Clicking on the green check (GitHub desktop site version, likely not available on mobile version) should show you the builds list. Then navigate on "details" link of the release build (like this one). TeamCity will ask you to login if you are not already. An anonymous logon option is available. Then go on the artifacts tab (here by example) and download what you need.

fredericDelaporte · 2018-03-15T11:00:15Z

About:

MySQL on

Windows - 4 tests are failing (same tests fail on Full .NET Framework on Windows with 6.10.x provider, 2 of them due to the bug in MySql data adapter);

As written later by Alexander, "the bug in MySql data adapter" is here.

Now the two others are also due to a bug in MySql data adapter 6.10, now reported here. (It is closely related to another one and may be considered a duplicate.)

This other bug is due to MySql.Data 6.10 command disposal closing now any open data reader found on the connection, be it related to the command or not. So a workaround would be to close previously opened command before opening a data reader with a new command. But in the case of the failing test, this would need introducing more coupling, because the current sequence of events implies a JoinedEnumerable of EnumerableImpl holding NHybridDataReader, which are for all of them but the last read into memory by the batcher at a place where their matching command is not known (and anyway, that is not the batcher responsibility to close commands here). The JoinedEnumerable disposes of its current EnumerableImpl as soon as it finishes iterating over it and before starting iterating the next one. This dispose causes the current EnumerableImpl to dispose of the command it is bound to, and when it is a MySql command, this command then dispose any reader found on the connection, resulting in closing the reader of the last EnumerableImpl in the JoinedEnumerable.

So another workaround could be to change JoinedEnumerable for ceasing disposing an EnumerableImpl when it has exhausted it, but instead disposing all of them when it has exhausted all of them. But well, I would rather wait for MySql Connector to get fixed.

bgrainger · 2018-03-20T06:24:54Z

I would rather wait for MySql Connector to get fixed.

This may be a long wait...

I have created a competing OSS library, https://github.com/mysql-net/MySqlConnector, that is a drop-in replacement for Oracle's Connector/NET (aka MySql.Data). (One of the motivating factors in creating this alternative was to fix longstanding Connector/NET bugs that weren't getting addressed. It also supported .NET Standard before Connector/NET did.)

I understand that many NHibernate users are using Connector/NET, so it makes sense to test with the library your users are using; however, if you'd like a higher-quality MySQL ADO.NET library then I suggest testing with MySqlConnector (either in addition to or instead of Connector/NET). (As the primary author of MySqlConnector, I'd be happy to assist with any integration questions.)

hazzik added t: New Feature c: Core p: Major labels Jan 11, 2018

hazzik force-pushed the netcoreapp2.0 branch from c511a94 to 04087a9 Compare January 11, 2018 02:52

fredericDelaporte reviewed Jan 11, 2018

View reviewed changes

hazzik force-pushed the netcoreapp2.0 branch 3 times, most recently from e948759 to 9779f81 Compare February 1, 2018 21:10

This was referenced Feb 3, 2018

Manually serialize system types in preparation for .NET Core. #1425

Closed

NHibernateLogger.GetNhibernateLoggerClass() throws NotImplementedException #1572

Closed

hazzik force-pushed the netcoreapp2.0 branch 8 times, most recently from d162f28 to 1945138 Compare February 9, 2018 04:28

hazzik force-pushed the netcoreapp2.0 branch 7 times, most recently from 55bad29 to 508beb9 Compare February 14, 2018 04:08

fredericDelaporte reviewed Feb 21, 2018

View reviewed changes

fredericDelaporte reviewed Feb 24, 2018

View reviewed changes

Split huge methods in smaller chunks

c4eb575

- When executing these methods on .NET Core on Linux they were failing with AccessViolationException crushing the application.

hazzik force-pushed the netcoreapp2.0 branch 2 times, most recently from 21ca57c to 3ebc5b6 Compare February 26, 2018 02:12

hazzik and others added 4 commits February 28, 2018 11:41

Add .NET Core 2.0 and .NET Standard 2.0 builds

90a6d1a

Install NUnitLite to run .NET Core tests

75f4216

Add AppVeyor build configuration

3c6cd76

Co-authored-by: Frédéric Delaporte <[email protected]>

Add Travis CI build configuration

d9df26a

hazzik force-pushed the netcoreapp2.0 branch from 3ebc5b6 to d9df26a Compare February 27, 2018 22:42

fredericDelaporte approved these changes Feb 28, 2018

View reviewed changes

hazzik merged commit 45a63bf into nhibernate:master Feb 28, 2018

hazzik added this to the 5.1 milestone Feb 28, 2018

hazzik added the r: Fixed label Feb 28, 2018

hazzik mentioned this pull request Feb 28, 2018

NH-3807 - Support for .NET Core 2.0 #954

Closed

hazzik added t: Fix and removed t: New Feature labels Feb 28, 2018

ngbrown reviewed Mar 2, 2018

View reviewed changes

fredericDelaporte mentioned this pull request Mar 2, 2018

NH-3807 - Support for .NET Core 2.0 #633

Closed

29 tasks

SzymonPobiega mentioned this pull request Mar 14, 2018

Support .NET Core Particular/NServiceBus.NHibernate#322

Closed

hazzik deleted the netcoreapp2.0 branch April 27, 2018 02:46

.NET Core 2.0 and .NET Standard 2.0 support #1523

.NET Core 2.0 and .NET Standard 2.0 support #1523

Uh oh!

Conversation

hazzik commented Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik commented Jan 11, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LightCZ commented Jan 24, 2018

Uh oh!

hazzik commented Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Feb 9, 2018

Uh oh!

hazzik commented Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik commented Feb 20, 2018 via email

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fredericDelaporte Feb 20, 2018

Choose a reason for hiding this comment

Uh oh!

hazzik Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hazzik commented Feb 22, 2018

Uh oh!

fredericDelaporte commented Feb 22, 2018

Uh oh!

Uh oh!

fredericDelaporte Feb 24, 2018

Choose a reason for hiding this comment

Uh oh!

hazzik Feb 24, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevenlauwers22 commented Feb 28, 2018

Uh oh!

ngbrown Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

cloviscoli commented Mar 2, 2018

Uh oh!

stephan-simondshealth-com-au commented Mar 7, 2018

Uh oh!

fredericDelaporte commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Mar 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bgrainger commented Mar 20, 2018

Uh oh!

Uh oh!

hazzik commented Jan 11, 2018 •

edited

Loading

hazzik commented Jan 24, 2018 •

edited

Loading

hazzik commented Feb 9, 2018 •

edited

Loading

fredericDelaporte commented Mar 8, 2018 •

edited

Loading

fredericDelaporte commented Mar 15, 2018 •

edited

Loading