Skip to content

Fix extra-lazy collection forgetting changes #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

Fix extra-lazy collection forgetting changes #1878

merged 2 commits into from
Oct 23, 2018

Conversation

fredericDelaporte
Copy link
Member

Fixes #1874

hazzik
hazzik previously approved these changes Oct 19, 2018
View reviewed changes
@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Oct 19, 2018 •
edited
Loading

Possible breaking-change (as demonstrated by NH-739 failure): AbstractPersistentCollection.AfterInitialize does no more perform queued operations. Queued operations are now run by a later call to a new method, ApplyPendingOperations. Concrete custom implementations relying on the queued operations to be done by their base AfterInitialize will need to be changed accordingly.

@hazzik hazzik mentioned this pull request Oct 21, 2018
Closed
@fredericDelaporte fredericDelaporte added this to the 5.2 milestone Oct 23, 2018
@fredericDelaporte fredericDelaporte merged commit 0309504 into nhibernate:master Oct 23, 2018
@fredericDelaporte fredericDelaporte deleted the extralazy-enumeration branch October 23, 2018 09:45
@hazzik
Copy link
Member

hazzik commented Dec 10, 2018

@fredericDelaporte can you check if this has fixed #1295?

@fredericDelaporte
Copy link
Member Author

No unit tests are provided there, and the opener states he was not able to fully reproduce it outside of his application. Moreover he does not states explicitly his case was an extra-lazy case, but it seems it can only be one.
This said, the part he was reproducing is no more reproducible since this PR.

@fredericDelaporte fredericDelaporte mentioned this pull request Dec 10, 2018
Closed
@maca88 maca88 mentioned this pull request Mar 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
possible breaking change r: Fixed t: Fix
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericDelaporte @hazzik