Extend IAccessOptimizer to support getting/setting single property value #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are some performance numbers of the added [Get\Set]PropertyValue methods: |
…ertyValueInvoker delegates
…tion for isBytecodeProviderImpl field
fredericDelaporte
previously approved these changes
Dec 30, 2018
| @@ -163,10 +163,10 @@ private static void EmitCastToReference(ILGenerator il, System.Type type) | |||
|
|
|||
| private GetPropertyValueInvoker GenerateGetPropertyValueMethod(IGetter getter) | |||
| { | |||
| if (getter == null) | |||
| return null; | |||
There was a problem hiding this comment.
I forgot the null case... Now that we do no more yield just null when the argument is not optimizable, the case where it is null has to be handled separately, because the null coalesce operator does not work on method groups. (And the ternary requires some explicit casting.)
fredericDelaporte
approved these changes
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach (#1942) to avoid reflection when
UseReflectionOptimizerenabled. Here I was forced to use IL asIOptimizableSetterexposes only anEmitmethod. I think that this approach is better, but is also more invasive and contains some ugly code to avoid a breaking change.