Skip to content

Fix missing cast when comparing a guid and string column in Sql Server #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2019

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Mar 6, 2019

Fixes #2040

@fredericDelaporte
Copy link
Member

Since this is likely a 5.2 regression, it should target 5.2.x. But I have not checked yet it was working in 5.1.x.

@maca88 maca88 changed the base branch from master to 5.2.x March 6, 2019 19:41
@maca88 maca88 force-pushed the SqlServerGuidCast branch from 1283972 to 82f9bc5 Compare March 6, 2019 19:49
@maca88
Copy link
Contributor Author

maca88 commented Mar 6, 2019

Changed the target to 5.2. I've ran the tests on 5.1.x branch and they all work.

@fredericDelaporte fredericDelaporte added this to the 5.2.5 milestone Mar 6, 2019
@fredericDelaporte
Copy link
Member

Thanks Maca.

Since we have just released 5.2.4, and that this regression is not major, I intend to wait a bit before releasing a 5.2.5, in case some other things need a fix before the end of the month. So this PR will wait a bit, in case we just have to add the release commit here if there is nothing else to fix at the end of the month.

@hazzik hazzik merged commit a6e7a44 into nhibernate:5.2.x Mar 9, 2019
@hazzik hazzik added the r: Fixed label Mar 9, 2019
@fredericDelaporte
Copy link
Member

I think about it a bit too late, but it seems SAP SQL Anywhere also needs a fix.

To spot it more easily while not failing PRs on 5.1x or earlier, I have enabled the build on master and 5.2.x. So we will still see troubles a bit too late, after PRs merges, but that will reduce a risk of releasing a regression on that database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants