Skip to content

Fix nullable Guid ToString is not translated correctly on some dialects #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Mar 9, 2019

No description provided.

@hazzik
Copy link
Member Author

hazzik commented Mar 9, 2019

I'll push a fix when tests will fail. Also, I'm not sure what branch shall I target to. Strictly speaking this is not a regression.

@hazzik
Copy link
Member Author

hazzik commented Mar 9, 2019

This is a follow-up to #2040

@hazzik hazzik marked this pull request as ready for review March 10, 2019 11:16
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for 5.2.x.

@fredericDelaporte fredericDelaporte added this to the 5.2.5 milestone Mar 10, 2019
@hazzik hazzik merged commit f1e54fc into nhibernate:5.2.x Mar 11, 2019
@hazzik hazzik changed the title Nullable Guid ToString does not produce correct code on some dialects Fix nullable Guid ToString is not translated correctly on some dialects Mar 11, 2019
@hazzik hazzik deleted the fix-nullable-guid-to-string branch March 15, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants