Release 5.1.5 #2074
Merged
Release 5.1.5 #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
Release5.1.5
branch
from
78828cc to
b720c5f
Compare
hazzik
approved these changes
Mar 20, 2019
|
No missing breaking change to add, due to #2085, which causes "duplicated" interface methods to be actually implemented by the base class method override, as with the dynamic proxy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may have a missing possible breaking change to add, depending on further investigations on #2052.
The missing possible breaking would be the fact that all interfaces of the proxy base class are now by default implemented and delegated to the loaded state. That is a change I was convinced the static proxy factory has done. But it seems some @bahusoid tests contradict this.