Skip to content

SessionFactoryImpl - throw AggregateHibernateException when schema update fails#2409

Merged
fredericDelaporte merged 4 commits into
nhibernate:masterfrom
ylukomskyi:bugfix/throw-on-schema-update
Jun 7, 2020
Merged

SessionFactoryImpl - throw AggregateHibernateException when schema update fails#2409
fredericDelaporte merged 4 commits into
nhibernate:masterfrom
ylukomskyi:bugfix/throw-on-schema-update

Conversation

@ylukomskyi
Copy link
Copy Markdown
Contributor

Resolves #2259

Copy link
Copy Markdown
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
The feature should also have a test checking it actually throws. And the setting parameter should be documented in the reference documentation.

Comment thread src/NHibernate/Cfg/Environment.cs Outdated
@ylukomskyi
Copy link
Copy Markdown
Contributor Author

Thanks for your contribution.
The feature should also have a test checking it actually throws. And the setting parameter should be documented in the reference documentation.

Thanks for the quick feedback. I can add a follow-up commit to address this.

@ylukomskyi
Copy link
Copy Markdown
Contributor Author

ylukomskyi commented May 31, 2020

Thanks for your contribution.
The feature should also have a test checking it actually throws. And the setting parameter should be documented in the reference documentation.

Thanks for the quick feedback. I can add a follow-up commit to address this.

I see that it has been taken care of already. Thanks @fredericDelaporte

@fredericDelaporte fredericDelaporte merged commit 111f755 into nhibernate:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema auto-update should throw errors

3 participants