Improve CriteriaAssertFixture #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngbrown
force-pushed
the
criteria-assert-fixture-fix
branch
from
7f9da44 to
8d2f544
Compare
bahusoid
approved these changes
Aug 16, 2020
hazzik
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is that the ReSharper unit test runner was reporting these tests as failures when the
AssertCriteriaAreEqualare expected to fail.The
try/catchalong with aAssert.pass()wasn't enough.Assert.Throwsdoes behave correctly.