Skip to content

Fix parameter detection for expression arguments #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

Fix parameter detection for expression arguments #2542

merged 2 commits into from
Sep 17, 2020

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Sep 15, 2020

Fix for a regression made by #2335.

Fixes #2537

@fredericDelaporte fredericDelaporte added this to the 5.3.4 milestone Sep 15, 2020
hazzik
hazzik reviewed Sep 16, 2020
View reviewed changes
src/NHibernate/Linq/Visitors/NhPartialEvaluatingExpressionVisitor.cs
@@ -157,7 +157,9 @@ private Expression EvaluateSubtree(Expression subtree)

private bool ContainsVariable(Expression expression)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maca88 can this method be moved to NhEvaluatableExpressionFilter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, it was placed here due to #2458, to evaluate expression like string.Fromat("{0}", variable).

@hazzik hazzik merged commit 63e82b7 into nhibernate:5.3.x Sep 17, 2020
@bahusoid bahusoid linked an issue Dec 29, 2020 that may be closed by this pull request
Unable to cast "System.Linq.Expressions.UnaryExpression" to "System.Linq.Expressions.LambdaExpression". #2537
Closed
bahusoid pushed a commit to bahusoid/nhibernate-core that referenced this pull request Aug 10, 2021
@maca88 @bahusoid
Fix parameter detection for expression arguments (nhibernate#2542)
916b902 
Fixes nhibernate#2537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik left review comments

@bahusoid bahusoid bahusoid approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.4
Development

Successfully merging this pull request may close these issues.

Unable to cast "System.Linq.Expressions.UnaryExpression" to "System.Linq.Expressions.LambdaExpression".
4 participants
@maca88 @hazzik @bahusoid @fredericDelaporte