Skip to content

Fix Queryable.Contains method for Linq provider #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2021
Merged

Fix Queryable.Contains method for Linq provider #2674

merged 2 commits into from
Feb 15, 2021

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Feb 11, 2021

I think this is a regression from #568, but I am not sure.

Fixes #2544

Should we backport it also to 5.2.x, 5.1.x and 5.0.x?

@fredericDelaporte fredericDelaporte added this to the 5.3.6 milestone Feb 14, 2021
@fredericDelaporte
Copy link
Member

fredericDelaporte commented Feb 14, 2021 •
edited
Loading

About back-porting, we also have #2471 (Linq issue too, with what looks like superfluous .AsQeryable calls causing a crash) which should ideally be back-ported down to 5.0.x. But both are quite minor, so maybe let it be (not back-ported) unless some other less minor thing had to be fixed in those older releases.
(Thinking about it, we may also back-port #2656 down to 5.1.x. It is a lack of disposal in a new feature, of a resource for which it does not seem to matter. And now we could also back-port #2677 down to 5.2 about a missing ConfigureAwait(false).)

@fredericDelaporte fredericDelaporte mentioned this pull request Feb 14, 2021
Closed
@bahusoid bahusoid linked an issue Feb 14, 2021 that may be closed by this pull request
Recognition error occurs using System.Linq.Queryable.Contains #2544
Closed
@fredericDelaporte fredericDelaporte merged commit 7a77430 into nhibernate:5.3.x Feb 15, 2021
bahusoid pushed a commit to bahusoid/nhibernate-core that referenced this pull request Aug 10, 2021
@maca88 @bahusoid
Fix Queryable.Contains method for Linq provider (nhibernate#2674)
456e72a 
Fixes nhibernate#2544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

@bahusoid bahusoid bahusoid approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.6
Development

Successfully merging this pull request may close these issues.

Recognition error occurs using System.Linq.Queryable.Contains
3 participants
@maca88 @fredericDelaporte @bahusoid