DateOnly and TimeOnly support #3712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Frédéric Delaporte <[email protected]>
Comment on lines
+19
to
+21
| { | ||
|
|
||
| protected override string MappingsAssembly |
There was a problem hiding this comment.
nit: undue blank line.
Suggested change
| { | |
| protected override string MappingsAssembly | |
| { | |
| protected override string MappingsAssembly |
Comment on lines
+266
to
+267
| } | ||
| public class TestEntity |
There was a problem hiding this comment.
nit: missing blank line.
Suggested change
| } | |
| public class TestEntity | |
| } | |
| public class TestEntity |
Comment on lines
+44
to
+48
| ///// <inheritdoc /> | ||
| //public override object Get(DbDataReader rs, string name, ISessionImplementor session) | ||
| //{ | ||
| // return Get(rs, rs.GetOrdinal(name), session); | ||
| //} |
| // object needs to have both class and serializable setup before it can | ||
| // be created. | ||
| RegisterType(typeof (Object), NHibernateUtil.Object, new[] {"object"}); | ||
| RegisterType(typeof (Object), NHibernateUtil.Object, new[] {"object"}); |
There was a problem hiding this comment.
nit: probable trouble in previous suggestion, missing indent.
Suggested change
| RegisterType(typeof (Object), NHibernateUtil.Object, new[] {"object"}); | |
| RegisterType(typeof (Object), NHibernateUtil.Object, new[] {"object"}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting DateOnly and TimeOnly. #2912
I have have working implementations of types that can store the values as int (20251028, 163215), but that may be something that should reside elsewhere.
I would very much like to support projecting properties like "Hour" and "Minute", even though a "ticks" based type is used. I had an implementation where the type itself could implement IHqlGeneratorForProperty, and the DateTimePropertiesHqlGenerator checked for this before going the default route. It worked well, but...