Eliminated double Persister resolution in Loader.InstanceNotYetLoaded flow #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…...) and session.Instantiate(...) get called from Loader.InstanceNotYetLoaded(...)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hazzik
reviewed
Mar 30, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fredericDelaporte
requested changes
Mar 30, 2017
Comment from fredericDelaporte: - The naming could be improved for code clarity: instanceClass should be renamed concretePersister and GetRowPersister would be renamed GetConcretePersister.
fredericDelaporte
previously approved these changes
Apr 6, 2017
hazzik
reviewed
Apr 6, 2017
hazzik
reviewed
Apr 16, 2018
|
I believe I've removed all breaking changes |
bahusoid
reviewed
Mar 15, 2019
hazzik
previously approved these changes
Mar 15, 2019
hazzik
changed the title
fredericDelaporte
approved these changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated double Persister resolution when Loader.LoadFromResultSet(...) and session.Instantiate(...) get called from Loader.InstanceNotYetLoaded(...)